allow tls_options to be of String #1540
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
janit42
force-pushed
the
main
branch
2 times, most recently
from
7c17410 to
a016d0d
Compare
|
@janit42 please rebase against main to get rid of the merge commit. |
the type of $tls_options has recently been changed to Array in 5131e0f while the code in lib/puppet/type/mysql_user.rb is able to work with it as an Array or a String. This change allows $tls_options to by a String in addition to Array, which re-establishes compatibility with other modules, like puppet-icinga Fixes puppetlabs#1539
thanks for the heads-up @bastelfreak ! Anything else I can do for now? |
bastelfreak
approved these changes
Mar 14, 2024
|
@janit42 can you maybe add a unit test for it? |
|
I don't think this is needed anymore - compatibility has been ensured in related icingia module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the type of $tls_options has recently been changed to Array in 5131e0f while the code in lib/puppet/type/mysql_user.rb is able to work with it as an Array or a String.
This change allows $tls_options to by a String in addition to Array, which re-establishes compatibility with other modules, like puppet-icinga
Fixes #1539